Dan Kenigsberg has posted comments on this change. Change subject: jsonrpc: VM_getStats ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35551/3/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 6695: # Get statistics about a running virtual machine. Line 6696: # Line 6697: # @vmID: The UUID of the VM Line 6698: # Line 6699: # @runHooks: if True it will run before_get_vm_stats > This is the kind of issue that I would like to avoid in the future. You are undoubtedly correct, and I'm happy that your patchset made us notice this glitch. Just a reminder: "-1" only means "this patch should not go in in its current form". Line 6700: # and after_get_vm_stats hooks Line 6701: # Line 6702: # Returns: Line 6703: # An array containing a single VmStats record -- To view, visit http://gerrit.ovirt.org/35551 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0657482b59ee0b3e943afda652e94906fe24739 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
