Yaniv Bronhaim has submitted this change and it was merged. Change subject: vm: ensure graphics configuration data in recovery ......................................................................
vm: ensure graphics configuration data in recovery Graphics Devices may be not sent by Engine. To cover that VDSM reconstructs them from other VM configuration data - which is safe to do since the information is there, just organized in a different way. The recovery path skips that step, so the configuration is inconsistent. Later in the creation path the configuration is assumed to be present (either fixed by VDSM or given by Engine), but it is not, and this makes the domain initialization fail in the last stages. This is evident when upgrading Hosted Engine. This issue was unnoticed so far because the reccomended upgrade path is to migrate VMs away from the host being upgraded, and that avoid and triggers the existing safety nets for the missing configuration data. Change-Id: I6ed99b3e1a62d1e4c5bff5722bce9a966b193c73 Bug-Url: https://bugzilla.redhat.com/1168709 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: http://gerrit.ovirt.org/36021 Reviewed-by: Michal Skrivanek <[email protected]> Reviewed-by: Vinzenz Feenstra <[email protected]> Reviewed-by: Martin Polednik <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Reviewed-on: http://gerrit.ovirt.org/36065 Reviewed-by: Yaniv Bronhaim <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Looks good to me, approved Francesco Romani: Verified Michal Skrivanek: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/36065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ed99b3e1a62d1e4c5bff5722bce9a966b193c73 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
