Federico Simoncelli has posted comments on this change.

Change subject: storageServer: Improve iscsi connection logging
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36028/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 414:         return True
Line 415: 
Line 416:     def getSessionInfo(self):
Line 417:         for session in iscsi.iterateIscsiSessions():
Line 418:             if self.isSession(session):
isSession is used here in the iscsi session loop to find the session info. 
Isn't that too much verbose?
Line 419:                 self._lastSessionId = session.id
Line 420:                 return session
Line 421: 
Line 422:         raise OSError(errno.ENOENT, "Session not found")


-- 
To view, visit http://gerrit.ovirt.org/36028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to