Dan Kenigsberg has posted comments on this change. Change subject: network: Inexistence of a network in libvirt should not be fatal to us ......................................................................
Patch Set 2: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34988/2//COMMIT_MSG Commit Message: Line 11: is at stake. Line 12: Line 13: A network missing in libvirt is a sign of a different failure Line 14: (and we are after you, traffic control!) but it must not harm the restoration Line 15: of networking (not only) after failed tests. but this patch is "killing the messenger" instead of finding the "different failure". It also changes vdsm semantics in a way that makes testDelWithoutAdd fail. It makes some sense to make vdsm-restore config more robust, but we are allowed to ignore this failure only in this flow, not on all delNetwork. Line 16: Line 17: Change-Id: Ia6ae4b359d543b6e3ee560a5cb021e31d037c035 -- To view, visit http://gerrit.ovirt.org/34988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6ae4b359d543b6e3ee560a5cb021e31d037c035 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
