Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck of iterator ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/36121/1/tests/ipwrapperTests.py File tests/ipwrapperTests.py: Line 157: bridge = tcTests._Bridge() Line 158: tcTests._checkDependencies() Line 159: mon = Monitor() Line 160: mon.start() Line 161: sleep(0.5) please add a big FIXME explaining when this must be removed. "fixing" a race with a sleep is humiliating - we must note that we know how silly it is (the git commit is no enough). Line 162: iterator = iter(mon) Line 163: Line 164: bridge.addDevice() # Generate an event to avoid blocking Line 165: iterator.next() -- To view, visit http://gerrit.ovirt.org/36121 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec49f21c76a1cd9d02e3fb1f36a4d4e4de7f057e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
