Francesco Romani has posted comments on this change. Change subject: hostdev: report physfn ......................................................................
Patch Set 5: (1 comment) Nice improvements http://gerrit.ovirt.org/#/c/35974/5/vdsm/hostdev.py File vdsm/hostdev.py: Line 37: """ Line 38: return 'pci_{}_{}_{}_{}'.format(domain[2:], Line 39: bus[2:], Line 40: slot[2:], Line 41: function[2:]) much nicer, thanks for the improvement. Could you enhance a bit more the docstring to explain the not-immediately-obvious-to-me reason why we need to skip the first 2 chars here? Just mention they are hex addresses is fine. Line 42: Line 43: Line 44: def _sriov_totalvfs(device_name): Line 45: with open('/sys/bus/pci/devices/{}/sriov_totalvfs'.format( -- To view, visit http://gerrit.ovirt.org/35974 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1c41b1fd7e0cab51c869ae4a7882072be2c3fad Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
