Yeela Kaplan has posted comments on this change. Change subject: utils: Make CommandPath try to find the executable ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36166/2/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 893: spawn Maybe we could just give distutils the paths as a parameter, and then we can get rid of the for loop? Line 894: self I'd prefer keeping the same as in line 887: s/ if self._cmd is None: /if not self._cmd: -- To view, visit http://gerrit.ovirt.org/36166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bfa722778e295e23f03791179bf8c53172d34b2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <t...@midokura.com> Gerrit-Reviewer: Antoni Segura Puimedon <t...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ryu Ishimoto <r...@midokura.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
