Yaniv Bronhaim has posted comments on this change. Change subject: schema: verify line length to be shorter than 80 ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36126/2/tests/schemaValidationTest.py File tests/schemaValidationTest.py: Line 46: longer.append('line [%d] %s' % (i + 1, line)) Line 47: Line 48: if len(longer) > 0: Line 49: raise AssertionError('Lines longer than 80\n%s' Line 50: % '\n'.join(longer)) you don't need to print the lines content .. just write the line number Line 51: Line 52: def _get_path(self): Line 53: testPath = os.path.realpath(__file__) Line 54: dirName = os.path.split(testPath)[0] Line 52: def _get_path(self): Line 53: testPath = os.path.realpath(__file__) Line 54: dirName = os.path.split(testPath)[0] Line 55: return os.path.join( Line 56: dirName, '..', 'vdsm', 'rpc', 'vdsmapi-schema.json') make the path absolute . i don't run it from tests dir usually Line 57: Line 58: def _validate(self, api_mod): Line 59: bridge = Bridge.DynamicBridge() Line 60: -- To view, visit http://gerrit.ovirt.org/36126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bdb45f80d9f57c5169b104a9b4e4ca1eef4258 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
