Dan Kenigsberg has posted comments on this change. Change subject: storageServer: Improve iscsi connection logging ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36028/3/vdsm/storage/storageServer.py File vdsm/storage/storageServer.py: Line 423: else: Line 424: self._lastSessionId = session.id Line 425: return session Line 426: Line 427: self.log.debug("Session mismatch: %s", [str(e) for e in errors]) > Minor (ignore if you're not pushing again for other reasons): "mismatches" Another note: using str() is a bad practice, since it explodes if e has a unicode character. In this case, I see no real danger, though. Line 428: raise OSError(errno.ENOENT, "Session not found") Line 429: Line 430: def isConnected(self): Line 431: try: -- To view, visit http://gerrit.ovirt.org/36028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9de4ec72f09777e84273933ff41e9d1424e7aa09 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
