Federico Simoncelli has posted comments on this change. Change subject: qemuimg: add support for convert progress ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/33910/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 204: Line 205: cmd = utils.ionice_cmd(cmd, utils.IOCLASS.IDLE) Line 206: cmd = utils.nice_cmd(cmd, utils.NICENESS.HIGH) Line 207: Line 208: self.execution = utils.CommandStream( > couldn't this be made _private? Done Line 209: cmd, self._recvstdout, self._recvstderr, cwd=cwd, Line 210: deathSignal=signal.SIGKILL) Line 211: Line 212: def _recvstderr(self, buffer): -- To view, visit http://gerrit.ovirt.org/33910 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
