mooli tayer has posted comments on this change. Change subject: tool: configurators package should only contain configurators. ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/34048/4/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 42: from .. import ( Line 43: service, Line 44: validate_ovirt_certs, Line 45: ) Line 46: from ... import utils > unrelated.. Saggi wanted this here. He said we should not fix in separate patches, since that would make git blame confusing. Instead when we change a file/import regardless to it there. he prefers this import since he always favors '(' over ',' Line 47: from ... import constants Line 48: Line 49: if utils.isOvirtNode(): Line 50: from ovirt.node.utils.fs import Config as NodeCfg -- To view, visit http://gerrit.ovirt.org/34048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I862469b19265ce7034d65b06c9d7b60e4b65a70f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches