Nir Soffer has posted comments on this change. Change subject: profile: transform into a subpackage ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/36010/3/lib/vdsm/profiling/__init__.py File lib/vdsm/profiling/__init__.py: Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA Line 17: # Line 18: # Refer to the README and COPYING files for full details of the license Line 19: # Line 20: Having code in __init__ is confusing, you never know what is a module and what is a name defined in __init__, which lead to annoying errors when you try to import names from the package, and having to look in the source to understand how things are implemented. How about keeping __init__.py empty, and put this this logic in another module? For example: from vdsm.profiling import profiler ... profiler.start() I'm not sure about the name (profiler), just the first thing that pop up. Line 21: import cpu Line 22: Line 23: Line 24: def start(): http://gerrit.ovirt.org/#/c/36010/3/tests/profileTests.py File tests/profileTests.py: Line 44 Line 45 Line 46 Line 47 Line 48 Lets separate this change it its own patch before this one. -- To view, visit http://gerrit.ovirt.org/36010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idfd925e566a9af69d4b42a70fa835b072bb1f7a0 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
