Nir Soffer has posted comments on this change. Change subject: profiling: avoid to crash VDSM if yappi is missing ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/36012/3//COMMIT_MSG Commit Message: Line 8: Line 9: Add protection around lazy yappi import Line 10: to avoid crashing VDSM in presence of inconsistent Line 11: configuration: profiling enabled but yappi package Line 12: not installed. I'm not sure that we need this protection - if you enable the cpu profiler and ignore the documentation (requires yappi) you deserve the crash. Line 13: Line 14: Provide error message explaining the failure, and Line 15: add consistency with more complex memory profiling Line 16: which benefits of this protection, and has Line 13: Line 14: Provide error message explaining the failure, and Line 15: add consistency with more complex memory profiling Line 16: which benefits of this protection, and has Line 17: a more complex setup. Why the memory profiler cannot use the same logic as the cpu profiler is using now? Line 18: Line 19: Change-Id: I8272b25afe507038f930929f4b51d6d8f5b73495 http://gerrit.ovirt.org/#/c/36012/3/lib/vdsm/profiling/cpu.py File lib/vdsm/profiling/cpu.py: Line 95: with _lock: Line 96: try: Line 97: import yappi Line 98: except ImportError as e: Line 99: logging.warning("Error starting cpu profiler: %s", e) This is a lie - should be: "Error importing yappi - cpu_profile_enable requires yappi package" Line 100: else: Line 101: # yappi start semantics are a bit too liberal, returning success Line 102: # if yappi is already started, happily having too different code Line 103: # paths that thinks they own the single process profiler. -- To view, visit http://gerrit.ovirt.org/36012 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8272b25afe507038f930929f4b51d6d8f5b73495 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
