Hello Yeela Kaplan,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36341
to review the following change.
Change subject: vmchannel: perfromance enhancment
......................................................................
vmchannel: perfromance enhancment
Change-Id: I64ce100ff88074618eb47e9e7c46ce9497b83f42
Signed-off-by: emarcian <[email protected]>
Signed-off-by: Yeela Kaplan <[email protected]>
---
M vdsm/clientIF.py
M vdsm/virt/vmchannels.py
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/36341/1
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index af143ce..7e106cf 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -60,7 +60,7 @@
"""
The client interface of vdsm.
- Exposes vdsm verbs as xml-rpc functions.
+ Exposes vdsm verbs as json-rpc or xml-rpc functions.
"""
_instance = None
_instanceLock = threading.Lock()
diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py
index eab1c6e..c143162 100644
--- a/vdsm/virt/vmchannels.py
+++ b/vdsm/virt/vmchannels.py
@@ -165,8 +165,10 @@
def _wait_for_events(self):
""" Wait for an epoll event and handle channels' timeout. """
events = NoIntrPoll(self._epoll.poll, 1)
- for (fileno, event) in events:
- self._handle_event(fileno, event)
+ if events:
+ for (fileno, event) in events:
+ _wait_for_events = threading.Thread(name='handle_events-%s' %
fileno, target=self._handle_event, args=(fileno, event))
+ _wait_for_events.start()
else:
self._update_channels()
if (self._timeout is not None) and (self._timeout > 0):
--
To view, visit http://gerrit.ovirt.org/36341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I64ce100ff88074618eb47e9e7c46ce9497b83f42
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eldad Marciano <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
