Dan Kenigsberg has posted comments on this change. Change subject: tests: Support DHCPv6 in dnsmasq and dhclient wrappers ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36347/2/tests/functional/dhcp.py File tests/functional/dhcp.py: Line 46: self.proc = None Line 47: Line 48: def start(self, interface, dhcp_range_from, dhcp_range_to, Line 49: dhcpv6_range_from=None, dhcpv6_range_to=None, router=None, Line 50: el6=False): in this level, this should be named "bind_dynamic", and should be properly documented below Line 51: # -p 0 don't act as a DNS server Line 52: # --dhcp-option=3,<router> advertise a specific gateway (or None) Line 53: # --dhcp-option=6 don't reply with any DNS servers Line 54: # -d don't daemonize and log to stderr http://gerrit.ovirt.org/#/c/36347/2/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 225: if attrs.get('d') == 0: Line 226: del attrs['d'] Line 227: Line 228: Line 229: def _system_is_el6(): Please add a comment: # REQUIRED_FOR: el6 Line 230: return (caps.getos() in (caps.OSName.RHEVH, caps.OSName.RHEL) Line 231: and caps.osversion()['version'].startswith('6')) Line 232: Line 233: -- To view, visit http://gerrit.ovirt.org/36347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ac7e88351dc7e737db6effeead5a76c0a1a61d1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
