Dan Kenigsberg has submitted this change and it was merged. Change subject: schema: verification of API.py and schema during UT ......................................................................
schema: verification of API.py and schema during UT In order to automate verification of API changes with schema we added a unit test which breaks build if there is any discrapency. The verification covers most of issues found: - number of args in verb and schema - optional args in schema vs default args in api - return value in command_info and schema Due to API module being loaded for schema verification we needed to fix bridgeTests.py Change-Id: If81cff3c988e00c8c4eda1809f481e1ae19398dd Signed-off-by: pkliczewski <[email protected]> Reviewed-on: http://gerrit.ovirt.org/35557 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Yaniv Bronhaim <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/Makefile.am M tests/bridgeTests.py A tests/schemaValidationTest.py M vdsm/rpc/Bridge.py 4 files changed, 169 insertions(+), 18 deletions(-) Approvals: Piotr Kliczewski: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/35557 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If81cff3c988e00c8c4eda1809f481e1ae19398dd Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
