Nir Soffer has uploaded a new change for review. Change subject: storageServer: Cleanup logging when mount fails ......................................................................
storageServer: Cleanup logging when mount fails - Remove unhelpful traceback if os.rmdir fails - Use logging.exception instead of exc_info=True - Use %r for revealing whitespace bugs in paths - Unify logging messages Change-Id: I24ae2c6ce71a1f20459977a8860dd6a1ebc45db3 Signed-off-by: Nir Soffer <[email protected]> --- M vdsm/storage/storageServer.py 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/36371/1 diff --git a/vdsm/storage/storageServer.py b/vdsm/storage/storageServer.py index f5a1b17..de88ec4 100644 --- a/vdsm/storage/storageServer.py +++ b/vdsm/storage/storageServer.py @@ -212,8 +212,8 @@ try: os.rmdir(self._getLocalPath()) except OSError: - self.log.warn("Failed to remove mount point directory: %s", - self._getLocalPath(), exc_info=True) + self.log.warn("Error removing mountpoint directory: %r", + self._getLocalPath()) raise t, v, tb else: try: @@ -224,8 +224,7 @@ try: self.disconnect() except OSError: - self.log.warn("Error while disconnecting after access" - "problem", exc_info=True) + self.log.exception("Error disconnecting") raise t, v, tb def isConnected(self): -- To view, visit http://gerrit.ovirt.org/36371 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24ae2c6ce71a1f20459977a8860dd6a1ebc45db3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
