Dima Kuznetsov has posted comments on this change. Change subject: qemu-img: Allow creation of zero-sized volumes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36276/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 127: cmd.extend(("-F", backingFormat)) Line 128: Line 129: cmd.append(image) Line 130: Line 131: if size is not None: > Then we need another test that test the command when size==0. This should b Done Line 132: cmd.append(str(size)) Line 133: Line 134: rc, out, err = utils.execCmd(cmd, cwd=cwdPath, deathSignal=signal.SIGKILL) Line 135: -- To view, visit http://gerrit.ovirt.org/36276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf8d493bcf3334bd96d96f5aa02cc564b7b83c9f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
