Dan Kenigsberg has posted comments on this change. Change subject: be smarter about forcing bridge removal ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/35926/14/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1013: self.assertEquals(bridge_index, get_bridge_index()) Line 1014: # the kernel bridge driver automatically updates the bridge to Line 1015: # the new minimum MTU of all of its connected interfaces Line 1016: self.assertMtu(BIG, NETWORK_NAME, second) Line 1017: rc, out, err = execCmd([EXT_IFDOWN, NETWORK_NAME]) > can you explain why will the test fail on a non-ifcfg configurator? For non-ifcfg, nothing creates the ifcfg-testnet file. ifup fails when it does not find it. Line 1018: self.assertEquals(rc, 0, 'ifdown failed: rc=%s' % (rc,)) Line 1019: rc, out, err = execCmd([EXT_IFUP, NETWORK_NAME]) Line 1020: self.assertEquals(rc, 0, 'ifup failed: rc=%s' % (rc,)) Line 1021: self.vdsm_net.refreshNetinfo() -- To view, visit http://gerrit.ovirt.org/35926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b68cae78370ab357dbdbc74d3d7c0311b28cf15 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
