Yaniv Bronhaim has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35940/1/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 447: frameHandler = self._frameHandler Line 448: while parser.pending > 0: Line 449: frame = parser.popFrame() Line 450: if hasattr(frameHandler, "handle_frame"): Line 451: frameHandler.handle_frame(self, frame) if attr not exist, why not directly clean the stack in one operation? Line 452: Line 453: def popFrame(self): Line 454: return self._parser.popFrame() Line 455: -- To view, visit http://gerrit.ovirt.org/35940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
