Dan Kenigsberg has uploaded a new change for review.

Change subject: make check: fix pyflakes test
......................................................................

make check: fix pyflakes test

Commit 321eabf5 broke pyflakes test by overriding the output of "find"
with a limitted WHITELIST. This patch appends the WHITELIST to all found
*.py files.

Change-Id: Icc6703ff409476d9c51e8e33d3f5cd950465a72a
Signed-off-by: Dan Kenigsberg <[email protected]>
---
M Makefile.am
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/36434/1

diff --git a/Makefile.am b/Makefile.am
index 2d74b19..ce93d29 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -107,10 +107,10 @@
 .PHONY: pyflakes
 pyflakes:
        python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
-       find . -path './.git' -prune -type f -o \
+       ( find . -path './.git' -prune -type f -o \
                -path './vdsm_compat' -prune -type f -o \
-               -name '*.py' -o -name '*.py.in'  | \
-               echo $(WHITELIST) | xargs $(PYFLAKES) | \
+               -name '*.py' -o -name '*.py.in' && \
+               echo $(WHITELIST) ) | xargs $(PYFLAKES) | \
                grep -w -v $(SKIP_PYFLAKES_ERR) | \
                while read LINE; do echo "$$LINE"; false; done
 


-- 
To view, visit http://gerrit.ovirt.org/36434
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc6703ff409476d9c51e8e33d3f5cd950465a72a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to