Dan Kenigsberg has posted comments on this change. Change subject: ip route: parse only first line of route ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36184/3/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 534: return _execCmd(command) Line 535: Line 536: Line 537: def routeShowTable(table): Line 538: command = [_IP_BINARY.cmd, '-o', 'route', 'show', 'table', table] > I suggest including the long options whenever we compose a commandline, e.g ack for long args. this option is added so that newline never breaks a route. With -oneline we can be sure that one line corresponds to exactly one row in the routing table. Line 539: return _execCmd(command) Line 540: Line 541: Line 542: def routeAdd(route, family=4, dev=None): -- To view, visit http://gerrit.ovirt.org/36184 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b655ddbbb2fdaa7ec57bc460bc593e40bac977e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
