Ido Barkan has posted comments on this change. Change subject: improve testSetupNetworksNiclessBridgeless readability ......................................................................
Patch Set 16: (2 comments) http://gerrit.ovirt.org/#/c/35913/16/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 847: @cleanupNet Line 848: def testSetupNetworksConvertVlanNetBridgeness(self): Line 849: """Convert a bridged networks to a bridgeless one and viceversa""" Line 850: Line 851: def setupNetworkBridged(bridged): > in this case, I personally prefer being explicit on being simple: depending Done Line 852: networks = {NETWORK_NAME: dict(vlan=VLAN_ID, nic=nics[0], Line 853: bridged=bridged)} Line 854: status, msg = self.vdsm_net.setupNetworks(networks, {}, Line 855: NOCHK) Line 855: NOCHK) Line 856: self.assertEqual(status, SUCCESS, msg) Line 857: self.assertNetworkExists(NETWORK_NAME, bridged) Line 858: Line 859: with dummyIf(1) as nics: > however, placing Done Line 860: setupNetworkBridged(True) Line 861: setupNetworkBridged(False) Line 862: setupNetworkBridged(True) Line 863: -- To view, visit http://gerrit.ovirt.org/35913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dd97c1a64ef3dd9deb96e65ed5ee9f31d26a443 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
