Dan Kenigsberg has posted comments on this change.

Change subject: jsonrpc: Image_upload missing in command_info
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/36515/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 422:     'Image_delete': {'ret': 'uuid'},
Line 423:     'Image_deleteVolumes': {'ret': 'uuid'},
Line 424:     'Image_getVolumes': {'ret': 'uuidlist'},
Line 425:     'Image_download': {'ret': 'uuid'},
Line 426:     'Image_upload': {'ret': 'uuid'},
This is out of alphabetical order. Please fix in a follow up - I understand 
that we are in great hurry.
Line 427:     'Image_mergeSnapshots': {'ret': 'uuid'},
Line 428:     'Image_move': {'ret': 'uuid'},
Line 429:     'Image_reconcileVolumeChain': {'ret': 'volumes'},
Line 430:     'Image_syncData': {'ret': 'uuid'},


-- 
To view, visit http://gerrit.ovirt.org/36515
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79e28fed4caf3da5bdfefe030e4cfccb823d81d7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to