Dan Kenigsberg has posted comments on this change. Change subject: New sysctl module ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36531/1/lib/vdsm/sysctl.py File lib/vdsm/sysctl.py: Line 33: set_rp_filter(dev, _RPFILTER_LOOSE) Line 34: Line 35: Line 36: def set_rp_filter_strict(dev): Line 37: set_rp_filter(dev, _RPFILTER_STRICT) > why not doing that directly in sysctl.conf and reload? we already do sysctl These configuration should be strictly non-persistent. We want to change them dynamically, when iscsi connections are created or removed. On boot time, we cannot tell which "dev" is to be passed to set_rp_filter_loose() and when. http://gerrit.ovirt.org/#/c/36531/1/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 359: @logDecorator Line 360: def hbaRescan(self): Line 361: return hba._rescan() Line 362: Line 363: @logDecorator > maybe a verb to reload sysctl.conf , but setting values can be done by runn see my former comment: sysctl.conf is about static, persistent configuration. These new supervdsm verbs are for ad-hoc usage. Line 364: def set_rp_filter_loose(self, dev): Line 365: sysctl.set_rp_filter_loose(dev) Line 366: Line 367: @logDecorator -- To view, visit http://gerrit.ovirt.org/36531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I950c85a6f8d69494482ff63e569cb17ffc723624 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amir Shladovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
