Dan Kenigsberg has posted comments on this change. Change subject: vm: downgrade logs about expected flows ......................................................................
Patch Set 4: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/34357/4/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4824: # We already hit few times the problem that after a live Line 4825: # migration the paths were not in sync anymore (BZ#1059482). Line 4826: if (hasattr(d, 'alias') and d.alias == alias Line 4827: and d.path != devPath): Line 4828: self.log.info('updating drive %s path from %s to %s', based on rereading the comment above, I think that these two log should remain warning. Line 4829: d.alias, d.path, devPath) Line 4830: d.path = devPath Line 4831: if d.path == devPath: Line 4832: d.name = name -- To view, visit http://gerrit.ovirt.org/34357 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
