Dan Kenigsberg has posted comments on this change. Change subject: signals: Handle signals to non-main threads ......................................................................
Patch Set 23: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/29392/23/lib/vdsm/infra/sigutils/__init__.py File lib/vdsm/infra/sigutils/__init__.py: Line 22: import os Line 23: import select Line 24: import signal Line 25: Line 26: import vdsm.infra.filecontrol as filecontrol This form of import would hunt us forever, right? Line 27: Line 28: _signal_poller = None Line 29: _signal_read_fd = None Line 30: http://gerrit.ovirt.org/#/c/29392/23/lib/vdsm/infra/sigutils/tests.py File lib/vdsm/infra/sigutils/tests.py: Line 23: import signal Line 24: import subprocess Line 25: import time Line 26: Line 27: import nose.tools as tools I would not mind dropping this funny "as tools" too... Line 28: Line 29: from .. import sigutils Line 30: Line 31: CHILD_SCRIPT = 'tests_child.py' -- To view, visit http://gerrit.ovirt.org/29392 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5dbcd00cec22ef12f2b6253b016dcbd0aa889583 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
