Petr Horáček has posted comments on this change.

Change subject: contrib: add useful zsh functions to assist in vdsm development
......................................................................


Patch Set 3:

(4 comments)

http://gerrit.ovirt.org/#/c/36344/3/contrib/zshrc
File contrib/zshrc:

Line 82: del_dummies() {
Line 83:     for nic in `ip l | awk '{print $2;}' | egrep "^dummy"`; do
Line 84:         sudo ip link del dev ${nic[0,-2]}
Line 85:     done
Line 86:     sudo rm /etc/sysconfig/network-scripts/ifcfg-dummy*
* without \
Line 87: }
Line 88: 
Line 89: del_bonds() {
Line 90:     for nic in `ip l | awk '{print $2;}' | egrep "^bond"`; do


Line 89: del_bonds() {
Line 90:     for nic in `ip l | awk '{print $2;}' | egrep "^bond"`; do
Line 91:         sudo echo "-${nic[0,-2]} "> /sys/class/net/bonding_masters
Line 92:     done
Line 93:     sudo rm /etc/sysconfig/network-scripts/ifcfg-bond\*
* with \
Line 94: }
Line 95: 
Line 96: del_bridges() {
Line 97:     for bridge in `brctl show | awk '{print $1;}' | grep 
test-network`; do


Line 151: }
Line 152: 
Line 153: vdsm_pep8() {
Line 154:     PEP8_BLACKLIST=config.py,constants.py,crossImportsTests.py,vdsm.py
Line 155:     /usr/bin/pep8 --exclude=$PEP8_BLACKLIST --filename '*.py,*.py.in' 
.
would be better with cd ~/code/vdsm, like vdsm_unit()
Line 156: }
Line 157: 
Line 158: vdsm_unit () {
Line 159:     cd ~/code/vdsm && \


Line 155:     /usr/bin/pep8 --exclude=$PEP8_BLACKLIST --filename '*.py,*.py.in' 
.
Line 156: }
Line 157: 
Line 158: vdsm_unit () {
Line 159:     cd ~/code/vdsm && \
vdsm folder could be stored in an variable
Line 160:     ./autogen.sh --system && make && \
Line 161:     cd tests && sudo ./run_tests_local.sh $1
Line 162: }
Line 163: 


-- 
To view, visit http://gerrit.ovirt.org/36344
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide4131db838640a5836fd029696849bced267308
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to