Dan Kenigsberg has posted comments on this change. Change subject: Enable autotools and run check depends rhev_build or fedora_koji_build ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36417/1/vdsm.spec.in File vdsm.spec.in: Line 21: %global rhev_build_config_opt --enable-rhev Line 22: %endif Line 23: Line 24: Line 25: %if 0%{rhev_build} || 0%{fedora_koji_build} > don't know. its only if we wouldn't cancel the "make check" part I guess. n this is relevant only if you have d/s patches that change configure.ac or Makefile.am (see following comment). However, we don't have such patches, so we don't need this. Line 26: %{!?enable_autotools:%define enable_autotools 1} Line 27: %else Line 28: # Default to skipping autoreconf. Distros can change just this one line Line 29: # (or provide a command-line override) if they backport any patches that Line 31: %{!?enable_autotools:%define enable_autotools 0} Line 32: %endif Line 33: Line 34: # Skips check since rhel default repos lack pep8 and pyflakes Line 35: %if ! 0%{?rhel} && ! 0%{?rhev_build} && ! 0%{fedora_koji_build} > we want with_check only for manual build , and not for rhel. therefore it n I must say that I'm confused myself by the long boolean... But why don't we want to have a check during Fedora koji builds? It's a nice precaution. but certainly there is no need to have ! 0%{?rhel} && ! 0%{?rhev_build} if it's not rhel, it's certainly not rhev. Line 36: %{!?with_check:%global with_check 1} Line 37: %else Line 38: %{!?with_check:%global with_check 0} Line 39: %endif -- To view, visit http://gerrit.ovirt.org/36417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd6bca40897db76f1461e2f84600efa8b8532ce Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
