Federico Simoncelli has posted comments on this change. Change subject: API: move diskSizeExtend logic from BindingXMLRPC ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36590/2/vdsm/API.py File vdsm/API.py: Line 589: return errCode['noVM'] Line 590: return v.diskReplicateFinish(srcDisk, dstDisk) Line 591: Line 592: def diskSizeExtend(self, driveSpecs, newSize): Line 593: if self._UUID == VM.BLANK_UUID: This logic doesn't belong to the VM object. The correct solution would be for engine to call VM.diskSizeExtend and Volume.updateSize depending if the VM is up or down. Anyway I understand that you're trying to fix this quickly so probably a good compromise is to move this logic (old BindingXMLRPC diskSizeExtend) in the Global class. Line 594: try: Line 595: volume = Volume( Line 596: driveSpecs['volumeID'], driveSpecs['poolID'], Line 597: driveSpecs['domainID'], driveSpecs['imageID']) -- To view, visit http://gerrit.ovirt.org/36590 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9014154f376609d8bd547b7c008954981785b551 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
