Nir Soffer has posted comments on this change. Change subject: vmchannel: performance enhancment. changing thread name ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/36342/1//COMMIT_MSG Commit Message: Line 4: Commit: emarcian <[email protected]> Line 5: CommitDate: 2014-12-22 15:36:29 +0200 Line 6: Line 7: vmchannel: performance enhancment. Line 8: changing thread name Can you explain in the commit message how this improve performance and why we need to improve it? Line 9: Line 10: Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c http://gerrit.ovirt.org/#/c/36342/1/vdsm/virt/vmchannels.py File vdsm/virt/vmchannels.py: Line 167: events = NoIntrPoll(self._epoll.poll, 1) Line 168: if events: Line 169: for (fileno, event) in events: Line 170: _handle_event = threading.Thread(name='handle_events-%s' % fileno, target=self._handle_event, args=(fileno, event)) Line 171: _handle_event.start() This change is not clear - what are you trying to do? Line 172: else: Line 173: self._update_channels() Line 174: if (self._timeout is not None) and (self._timeout > 0): Line 175: self._handle_timeouts() -- To view, visit http://gerrit.ovirt.org/36342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8489ec3a65ed9025eb91dfc2f408450b02fd7e0c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eldad Marciano <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
