Dan Kenigsberg has posted comments on this change. Change subject: service: make service compatible with systemctl reload rc ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36491/3/lib/vdsm/tool/service.py File lib/vdsm/tool/service.py: Line 296: cmd = [_SERVICE.cmd, srvName, "reload"] Line 297: rc, out, err = _execSysvEnv(cmd) Line 298: status = service_status(srvName, False) Line 299: if (rc == 0) and (status != 0): Line 300: rc = 1 Please give a hint to the user why this has happened, something like err = 'reload failed since service was not running' Line 301: return (rc, out, err) Line 302: Line 303: @_sysvNative Line 304: def _serviceIsManaged(srvName): -- To view, visit http://gerrit.ovirt.org/36491 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I878fb898204f7a8a564941b43b12c024ef208765 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
