Dan Kenigsberg has posted comments on this change. Change subject: ipwrapperTests: prevent infinite stuck ......................................................................
Patch Set 9: Code-Review-1 (1 comment) tiny tiny nit http://gerrit.ovirt.org/#/c/35901/9/tests/ipwrapperTests.py File tests/ipwrapperTests.py: Line 165: def _timeout(): Line 166: mon.stop() Line 167: err_msg = 'test omitted: waiting too long for a monitor event' Line 168: logging.error(err_msg) Line 169: sys.stderr.write(err_msg) please add a newline, or stderr would become a mess Line 170: timer = Timer(3, _timeout) Line 171: timer.start() Line 172: try: Line 173: # FIXME: sometimes mon.start() is returned before properly -- To view, visit http://gerrit.ovirt.org/35901 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie71eb5b33cabf5402f00815aa603bbc384159d56 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
