Petr Horáček has posted comments on this change. Change subject: init: wait for network service ......................................................................
Patch Set 3: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/36647/3//COMMIT_MSG Commit Message: Line 6: Line 7: init: wait for network service Line 8: Line 9: The network service is not synchronous. It returns before all of the Line 10: interfaces that itstarted are actually up. it started Line 11: Line 12: This is particularly problematic when upgrading from ovirt-3.4 to Line 13: ovirt-3.5, as one of the first pre-run tasks is to upgrade network Line 14: configuration to the "unified persistence" model. http://gerrit.ovirt.org/#/c/36647/3/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 30: Line 31: _all_have_ipv4(){ Line 32: local dev Line 33: Line 34: for dev in $1; no need for semicolon Line 35: do Line 36: _has_ipv4 "$dev" || return 1 Line 37: done Line 38: return 0 Line 65: -e '{ s/^ifcfg-//g;s/[0-9]/ &/}' | \ Line 66: LC_ALL=C sort -k 1,1 -k 2n | \ Line 67: LC_ALL=C sed 's/ //') Line 68: Line 69: for dev in $interfaces; no need for semicolon Line 70: do Line 71: ifcfg="ifcfg-$dev" Line 72: grep -q '# Generated by VDSM version' "$ifcfg" || continue Line 73: grep -q 'ONBOOT=yes' "$ifcfg" || continue -- To view, visit http://gerrit.ovirt.org/36647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89abe7a83673c2232f8b249f23a39e27e01e50be Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
