Nir Soffer has posted comments on this change. Change subject: Simplify tests for qemuimg to allow additional capabilities checks ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/36366/3/tests/qemuimgTests.py File tests/qemuimgTests.py: Line 248: def supported(self, command, result): Line 249: def check(arg): Line 250: self.assertEqual(command, arg) Line 251: return result Line 252: return check > But extract to a class and run an assertEqual() in that class means the ext Extending TestCaseBase will be the simplest solution. Line 253: Line 254: Line 255: class CompatTests(TestCaseBase): Line 256: -- To view, visit http://gerrit.ovirt.org/36366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I386772bf2a25a880b5ad387f284679eed81c5615 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
