Dan Kenigsberg has submitted this change and it was merged. Change subject: init: wait for network service ......................................................................
init: wait for network service The network service is not synchronous. It returns before all of the interfaces that it started are actually up. This is particularly problematic when upgrading from ovirt-3.4 to ovirt-3.5, as one of the first pre-run tasks is to upgrade network configuration to the "unified persistence" model. This patch waits up to 10 seconds for vdsm-controlled interfaces to obtain their IPv4 address. It's a hack, an ugly hack, that does not solve the inherent race. The race would be solved only when we tap into netlink's event monitor and stall ifup until the interface is actually up. Change-Id: I89abe7a83673c2232f8b249f23a39e27e01e50be Bug-Url: https://bugzilla.redhat.com/1174611 Signed-off-by: Dan Kenigsberg <dan...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/36647 Reviewed-by: Ido Barkan <ibar...@redhat.com> Reviewed-by: Petr Horáček <phora...@redhat.com> Reviewed-by: Douglas Schilling Landgraf <dougsl...@redhat.com> Tested-by: Douglas Schilling Landgraf <dougsl...@redhat.com> --- M init/vdsmd_init_common.sh.in 1 file changed, 61 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, but someone else must approve Ido Barkan: Looks good to me, but someone else must approve Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89abe7a83673c2232f8b249f23a39e27e01e50be Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <celeb...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <t...@midokura.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Fabian Deutsch <fabi...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
