Ondřej Svoboda has uploaded a new change for review.

Change subject: IpConfig: remove an unneeded check
......................................................................

IpConfig: remove an unneeded check

objectivizeNetwork always populates IpConfig's inet4 and inet6 parameters
(which, in turn, can contain Nones when IP autoconfiguration is used).

Change-Id: I09a5d1e3468004f529c2bc9708cff2243c16241a
Signed-off-by: Ondřej Svoboda <osvob...@redhat.com>
---
M vdsm/network/models.py
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/36712/1

diff --git a/vdsm/network/models.py b/vdsm/network/models.py
index 3cd78ae..75849c7 100644
--- a/vdsm/network/models.py
+++ b/vdsm/network/models.py
@@ -478,9 +478,6 @@
 
     def __init__(self, inet4=None, inet6=None, bootproto=None, blocking=False,
                  ipv6autoconf=None, dhcpv6=None):
-        if inet4 is None and inet6 is None:
-            raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'You need to specify '
-                                     'IPv4 or IPv6 or both address.')
         if ((inet4 and inet4.address and bootproto == 'dhcp') or
            (inet6 and inet6.address and (ipv6autoconf or dhcpv6))):
             raise ConfigNetworkError(ne.ERR_BAD_ADDR, 'Static and dynamic ip '


-- 
To view, visit http://gerrit.ovirt.org/36712
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09a5d1e3468004f529c2bc9708cff2243c16241a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to