Amador Pahim has posted comments on this change. Change subject: tests: "-T src_cache" option in "qemu-img convert" command ......................................................................
Patch Set 2: Verified+1 (1 comment) http://gerrit.ovirt.org/#/c/36374/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 273: Line 274: Line 275: @utils.memoized Line 276: def _supports_src_cache(command): Line 277: return _fresh_supports_src_cache(command) Not pretty, I agree. But simplest way to get rid of memoized during tests before cache invalidate option. Line 278: Line 279: Line 280: # TODO: Drop this function, move its code to _supports_src_cache() and ajust Line 281: # tests using it when we are able to invalidate cache in utils.memoized -- To view, visit http://gerrit.ovirt.org/36374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie385dda479424dee147d0a917388b662dbb0cecd Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
