Dan Kenigsberg has posted comments on this change. Change subject: Using --enable-koji to configure spec for koji build ......................................................................
Patch Set 6: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36577/6/Makefile.am File Makefile.am: Line 143: rpmbuild -ts $(if $(BUILDID),--define="extra_release .$(BUILDID)") $(DIST_ARCHIVES) Line 144: Line 145: rpm: dist Line 146: rpmbuild -ta $(if $(BUILDID),--define="extra_release .$(BUILDID)") \ Line 147: $(WITH_HOOKS) $(RHEV_BUILD) $(KOJI_BUILD) $(DIST_ARCHIVES) I love shorter lines, an see no reason for so many tabs. Line 148: Line 149: dist-hook: gen-VERSION gen-ChangeLog Line 150: .PHONY: gen-VERSION gen-ChangeLog Line 151: http://gerrit.ovirt.org/#/c/36577/6/vdsm.spec.in File vdsm.spec.in: Line 11: %global snlk_group @SNLKGROUP@ Line 12: %global snlk_user @SNLKUSER@ Line 13: %global cdrom_group @CDROMGROUP@ Line 14: Line 15: # koji build - overridable using rpmbuild --define "koji_build 1" you introduce a new koji_build macro, instead of using the existing fedora_koji_build Line 16: %{!?koji_build: %global fedora_koji_build 0} Line 17: Line 18: # RHEV build - overridable using rpmbuild --define "rhev_build 1" Line 19: %{!?rhev_build: %global rhev_build 0} -- To view, visit http://gerrit.ovirt.org/36577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6997354be1c02a3775984115c5e35a4b365345c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
