Dan Kenigsberg has posted comments on this change. Change subject: netinfo: Split a DHCPv4-specific portion from a branch in _parse_lease_file ......................................................................
Patch Set 2: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/36836/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-01-13 12:07:38 +0100 Line 4: Commit: Ondřej Svoboda <osvob...@redhat.com> Line 5: CommitDate: 2015-01-13 14:50:56 +0100 Line 6: Line 7: netinfo: Split a DHCPv4-specific portion from a branch in _parse_lease_file The purpose of this patch is not clear... Line 8: Line 9: The lines starting with " expire" are only in v4 leases, not in v6. Line 10: Line 11: Also do not require the callers of _get_dhclient_ifaces to know the paths: Line 7: netinfo: Split a DHCPv4-specific portion from a branch in _parse_lease_file Line 8: Line 9: The lines starting with " expire" are only in v4 leases, not in v6. Line 10: Line 11: Also do not require the callers of _get_dhclient_ifaces to know the paths: is this related to v4 vs v6? in any case, it makes sense to be placed in its own patch. Line 12: Line 13: Make _DHCLIENT_LEASES_GLOBS a default value of _get_dhclient_ifaces, which Line 14: localizes the lease files stuff in one place. Line 15: -- To view, visit http://gerrit.ovirt.org/36836 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3367746310364be78be69b8c59528c2144f19d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
