Dan Kenigsberg has posted comments on this change. Change subject: block: simplify zeroImgVolumes using threads ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35630/3/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 48: from storage_mailbox import MAILBOX_SIZE Line 49: import resourceManager as rm Line 50: import mount Line 51: import supervdsm as svdsm Line 52: from threadLocal import vars > Yeah... actually I use it for logging purposes... to tie the thread to the I'm pretty sure that we agreed to split this patch. One patch should simplify the current code (as the commit message says), and a followup would make at fully-fledged task out of it. didn't we? Line 53: import volume Line 54: Line 55: STORAGE_DOMAIN_TAG = "RHAT_storage_domain" Line 56: STORAGE_UNREADY_DOMAIN_TAG = STORAGE_DOMAIN_TAG + "_UNREADY" -- To view, visit http://gerrit.ovirt.org/35630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665d863085842de8ff93c9aacf7c26277dfb031d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
