Nir Soffer has posted comments on this change. Change subject: virt: faster getAllVmStats ......................................................................
Patch Set 2: (1 comment) Looks good, can you explain the id change in vm.py? http://gerrit.ovirt.org/#/c/35140/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 1881: Please note that some values are provided by client (engine) Line 1882: but can change as result as interaction with libvirt (display*) Line 1883: """ Line 1884: stats = { Line 1885: 'vmId': self.conf['vmId'], Is this becasue we were adding the id externally in API.getAllVMStats? Line 1886: 'pid': self.conf['pid'], Line 1887: 'vmType': self.conf['vmType'], Line 1888: 'kvmEnable': self._kvmEnable, Line 1889: 'acpiEnable': self.conf.get('acpiEnable', 'true')} -- To view, visit http://gerrit.ovirt.org/35140 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1ed3f49c236086c6184973762d9909d7f79bf7e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
