Nir Soffer has posted comments on this change. Change subject: multipath configurator: raise only if service is active ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36387/8/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 146: utils.execCmd([constants.EXT_MULTIPATH, "-F"]) Line 147: Line 148: try: Line 149: service.service_reload("multipathd") Line 150: except service.ServiceOperationError: Can you document when this exception is raised, and why we must check if the service is running? Just to make it easier for the next one reading this code. Can also be in another patch if you like. Line 151: status = service.service_status("multipathd", False) Line 152: if status == 0: Line 153: raise Line 154: -- To view, visit http://gerrit.ovirt.org/36387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e8eceaaa486f05b1ea4f1733df669b2a44682a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
