Dan Kenigsberg has posted comments on this change. Change subject: Move NUMA collecting code to stats thread ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36906/1//COMMIT_MSG Commit Message: Line 7: Move NUMA collecting code to stats thread Line 8: Line 9: NUMA collecting was performed any time the .get() method was Line 10: invoked. That caused a serious slow down. This patch moves Line 11: the collecting to where all the other stats are collected. yes, it makes sense that going over to supervdsm asynchronously would reduce getVmStats's latency. Is it really the solution to the cited bug? If so, please provide hard numbers in the commit message. Line 12: Line 13: Change-Id: I3fff147d892ecbe7e01629a6c9428f911672fcdd Line 14: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1182094 -- To view, visit http://gerrit.ovirt.org/36906 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fff147d892ecbe7e01629a6c9428f911672fcdd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
