Dan Kenigsberg has posted comments on this change. Change subject: sampling: vm: use bulk-stats-style sample format ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/36731/3/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 736: Line 737: Line 738: def translateCpuSample(oldInfo): Line 739: if oldInfo is None: Line 740: return None please add a newline post an early return. Line 741: return { Line 742: 'cpu.user': oldInfo['user_time'], Line 743: 'cpu.system': oldInfo['system_time'], Line 744: 'cpu.time': oldInfo['cpu_time']} Line 787: vcpuMax = max(vcpuMax, vcpuNum) Line 788: newInfo['vcpu.%d.state' % vcpuNum] = vcpuState Line 789: newInfo['vcpu.%d.time' % vcpuNum] = vcpuTime Line 790: newInfo['vcpu.%d.physical' % vcpuNum] = pcpuNum Line 791: # yep, just guesswork # we prefer to fake the number of online vcpus over adding a specific libvirt call to extract it. Line 792: newInfo['vcpu.maximum'] = vcpuMax -- To view, visit http://gerrit.ovirt.org/36731 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic43b1ecb5e3503f22d3b45576310a169de852b47 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches