Vinzenz Feenstra has posted comments on this change. Change subject: virt: Check the full range of replaceble chars in filtering ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36952/1/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 45: union(set((0xFFFE, 0xFFFF))) Line 46: Line 47: Line 48: def _getRestrictedAndReplacement(): Line 49: return __RESTRICTED_CHARS, __REPLACEMENT_CHAR > We don't need this function - the test can access the private constants dir Well the tests are failing without this, I guess that it might be the double underscores which cause the issue. I have to check it with a single one Line 50: Line 51: Line 52: def _filterXmlChars(u): Line 53: """ -- To view, visit http://gerrit.ovirt.org/36952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida62ef962e2e35a7b110c1e66b3a30ec3700f85d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
