Francesco Romani has posted comments on this change. Change subject: Live Merge: Update drive.format after active layer merge ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36923/1/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 4984: volInfo = getVolumeInfo(device, volumeID) Line 4985: Line 4986: # Path must be set with the value being used by libvirt Line 4987: device['path'] = drive.path = volInfo['path'] = activePath Line 4988: device['format'] = drive.format = driveFormat I don't like multiple assignement, but they are already there and I can live with that. Line 4989: device['volumeID'] = drive.volumeID = volumeID Line 4990: device['volumeInfo'] = drive.volumeInfo = volInfo Line 4991: for v in device['volumeChain']: Line 4992: if v['volumeID'] == volumeID: -- To view, visit http://gerrit.ovirt.org/36923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb64bbfe798a27896442a173b7dac41cebc92543 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
