Yeela Kaplan has posted comments on this change.

Change subject: spec: require selinux that allows logrotate to manage virt_cache
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/36861/1/vdsm.spec.in
File vdsm.spec.in:

Line 215: Requires: fence-agents-all
Line 216: Requires: lvm2
Line 217: Requires: python
Line 218: Requires: policycoreutils-python
Line 219: Requires: selinux-policy-targeted >= 3.12.1-153.el7_0.13
> on el7 we're good?
yes, Allow logrotate to manage virt_cache_t type is included in
3.12.1-153.el7_0.12
Line 220: %else
Line 221: Requires: python
Line 222: Requires: device-mapper-multipath >= 0.4.9-52
Line 223: Requires: e2fsprogs >= 1.41.12-11


Line 225: Requires: kernel >= 2.6.32-465
Line 226: Requires: initscripts >= 9.03.31-2.el6_3.1
Line 227: Requires: policycoreutils >= 2.0.83-19.30
Line 228: Requires: policycoreutils-python >= 2.0.83-19.47.el6_6.1
Line 229: Requires: selinux-policy-targeted >= 3.7.19-260.el6_6.2
build is available in brew
Line 230: Requires: lvm2 >= 2.02.100-5
Line 231: Requires: logrotate < 3.8.0
Line 232: %endif
Line 233: %else


Line 241: Requires: policycoreutils-python
Line 242: Requires: sed >= 4.2.1-10
Line 243: Requires: ed
Line 244: Requires: lvm2 >= 2.02.98-15
Line 245: Requires: selinux-policy-targeted >= 3.12.1-177
> is the package available already?
It is available in koji
Line 246: # In order to avoid a policycoreutils bug (rhbz 889698) when selinux 
is
Line 247: # disabled we now require the version 2.1.13-55 (or newer) of Fedora.
Line 248: Requires: policycoreutils >= 2.1.13-55
Line 249: Requires: systemd >= 197-1.fc18.2


-- 
To view, visit http://gerrit.ovirt.org/36861
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98e87d1f8f238f389b97b5660f1ddcb049485310
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to