Dan Kenigsberg has uploaded a new change for review.

Change subject: tests: dummy: provide more info upon failure
......................................................................

tests: dummy: provide more info upon failure

Expose a bit more information regarding the underlying failure when
failing to remove or set IP on a device.

Change-Id: I4452ef5c03c14087b7395584cfa10d76ca8a3a88
Signed-off-by: Dan Kenigsberg <[email protected]>
---
M tests/functional/dummy.py
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/37047/1

diff --git a/tests/functional/dummy.py b/tests/functional/dummy.py
index 4713290..92ce563 100644
--- a/tests/functional/dummy.py
+++ b/tests/functional/dummy.py
@@ -31,8 +31,9 @@
     dummy_name = random_iface_name(prefix, max_length)
     try:
         linkAdd(dummy_name, linkType='dummy')
-    except IPRoute2Error:
-        raise SkipTest('Failed to load a dummy interface')
+    except IPRoute2Error as e:
+        raise SkipTest('Failed to load a dummy interface %s: %s' %
+                       (dummy_name, e))
     else:
         return dummy_name
 
@@ -52,8 +53,8 @@
 def setIP(dummyName, ipaddr, netmask, family=4):
     try:
         addrAdd(dummyName, ipaddr, netmask, family)
-    except IPRoute2Error:
-        raise SkipTest('Failed to set device ip')
+    except IPRoute2Error as e:
+        raise SkipTest('Failed to set device ip: %s' % e)
 
 
 def setLinkUp(dummyName):


-- 
To view, visit http://gerrit.ovirt.org/37047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4452ef5c03c14087b7395584cfa10d76ca8a3a88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to