Francesco Romani has posted comments on this change. Change subject: Added support for reporting the timezone and os info ......................................................................
Patch Set 5: Code-Review-1 (4 comments) Schema needs to be updated. http://gerrit.ovirt.org/#/c/28940/5/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3786: # Line 3787: # @clientIp: The IP address of the client connected to the display Line 3788: # Line 3789: # @guestOsInfo: #optional Guest OS information like architecture, Line 3790: # type, and version (Since 4.15.0) you probably want to bump the version here Line 3791: # Line 3792: # @guestTimezone: #optional Timezone and time offset of the guest OS Line 3793: # (Since 4.15.0) Line 3794: # Line 3789: # @guestOsInfo: #optional Guest OS information like architecture, Line 3790: # type, and version (Since 4.15.0) Line 3791: # Line 3792: # @guestTimezone: #optional Timezone and time offset of the guest OS Line 3793: # (Since 4.15.0) same Line 3794: # Line 3795: # Since: 4.14.1 Line 3796: ## Line 3797: {'type': 'VMFullInfo', Line 3807: 'displayPort': 'uint', 'guestIPs': 'str', Line 3808: 'guestDiskMapping': 'GuestDisksMappingMap', Line 3809: 'smartcardEnable': 'bool', 'nicModel': 'VmInterfaceDeviceModel', Line 3810: 'pitReinjection': 'bool', 'status': 'str', 'clientIp': 'str', Line 3811: '*guestOsInfo': 'VMGuestOsInfo', We need to define this type in the schema, don't we? Line 3812: '*guestTimezone': 'VMGuestTimezone'}} Line 3813: Line 3814: ## Line 3815: # @Host.getVMFullList: Line 3808: 'guestDiskMapping': 'GuestDisksMappingMap', Line 3809: 'smartcardEnable': 'bool', 'nicModel': 'VmInterfaceDeviceModel', Line 3810: 'pitReinjection': 'bool', 'status': 'str', 'clientIp': 'str', Line 3811: '*guestOsInfo': 'VMGuestOsInfo', Line 3812: '*guestTimezone': 'VMGuestTimezone'}} same Line 3813: Line 3814: ## Line 3815: # @Host.getVMFullList: Line 3816: # -- To view, visit http://gerrit.ovirt.org/28940 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadb85a5003fcb4693b5a1174655acf59193340b5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
